@jasonleenaylor reviewed 39 of 41 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mark-sil)

Src/xWorks/DictionaryConfigurationModel.cs line 340 at r2 (raw file):

		/// Gets the reversal configuration model for the specified writing system.
		/// </summary>
		public static DictionaryConfigurationModel GetReversalConfigurationModel(string ws, LcmCache cache, PropertyTable propTable)

I'm sure this method existed somewhere already...or did you move it.

Src/xWorks/RecordClerk.cs line 476 at r2 (raw file):

		{
			CheckDisposed();
			return m_list.PropertyTableId("sorter", dictConfig);

Does this handle 'null' safely?

Src/xWorks/RecordClerk.cs line 3092 at r2 (raw file):

		/// </summary>
		/// <param name="reversalGuid">The Guid that identifies the reversal.</param>
		public int[] GetReversalFilteredAndSortedEntries(Guid reversalGuid, DictionaryPublicationDecorator decorator, DictionaryConfigurationModel revConfig)

I don't love having these methods here. RecordClerk should in theory be ignorant of such specific list types.
Could they be added as extension methods from some Dictionary or Reversal classes?

Code quote:

		/// <summary>
		/// Gets the filtered and sorted dictionary entries.
		/// </summary>
		public int[] GetDictionaryFilteredAndSortedEntries(DictionaryPublicationDecorator decorator)
		{
			// Filters and Sorts the list, then populates the virtual cache with the result.
			m_list.FilterAndSortList();

			// Gets the entries from the virtual cache.
			int[] retEntries = decorator.VecProp(Cache.LangProject.LexDbOA.Hvo, VirtualFlid);

			return retEntries;
		}

		/// <summary>
		/// Gets the filtered and sorted entries for the specified reversal.
		/// </summary>
		/// <param name="reversalGuid">The Guid that identifies the reversal.</param>
		public int[] GetReversalFilteredAndSortedEntries(Guid reversalGuid, DictionaryPublicationDecorator decorator, DictionaryConfigurationModel revConfig)

Reviewable status: 37 of 41 files reviewed, all discussions resolved (waiting on @jasonleenaylor)

Src/xWorks/DictionaryConfigurationModel.cs line 340 at r2 (raw file):

I don’t think it previously existed.  Part of it came from FwXWindow.ShowUploadToWebonaryDialog().

Src/xWorks/RecordClerk.cs line 476 at r2 (raw file):

I think it does. Only the override for reversals uses the config, and if it is null then PropertyTableId() falls back to the old behavior of getting the "ReversalIndexPublicationLayout" from the property table; which should only happen when the Gui is being used.

Src/xWorks/RecordClerk.cs line 3092 at r2 (raw file):

   Moved methods to ExportService

@jasonleenaylor reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mark-sil)